[docs] Close context menu if repeated #22463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
force-pushed
the
docs/fix-contextmenu
branch
from
12af6fb to
ff998fc
Compare
oliviertassinari
approved these changes
Sep 3, 2020
2 tasks
|
If this solution looks like merged and is closed, why this problem still exists in official releases? |
|
@TomasKomprs Because it was fixed in v5 (assuming you are still on v4) |
@oliviertassinari Hi, thank you. Yes I'm still on v4. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19145
new contextmenu demo
Closer to how native context menus behave in chrome 84 with ubuntu 18.04. It's missing that right click on a contextmenu item acts like a click but I couldn't make it work. Might require more involved work.
Simplified types along the way.