Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paper] Display elevation warning when rendering #22494

Merged
merged 6 commits into from
Sep 6, 2020
Merged

[Paper] Display elevation warning when rendering #22494

merged 6 commits into from
Sep 6, 2020

Conversation

nesso-pfl
Copy link
Contributor

Fix #20064

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 5, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 9493318

@oliviertassinari oliviertassinari added the component: Paper This is the name of the generic UI component, not the React module! label Sep 5, 2020
@nesso-pfl nesso-pfl force-pushed the use-theme-instead-of-classes branch from 98546e3 to 3324cec Compare September 5, 2020 14:25
nesso-pfl and others added 2 commits September 5, 2020 23:30
@nesso-pfl nesso-pfl force-pushed the use-theme-instead-of-classes branch from 3324cec to 5bd54bc Compare September 5, 2020 14:30
@nesso-pfl nesso-pfl marked this pull request as draft September 5, 2020 14:37
@nesso-pfl nesso-pfl marked this pull request as ready for review September 5, 2020 14:54
@nesso-pfl
Copy link
Contributor Author

(Rebased

@eps1lon eps1lon changed the title [Paper] Improve how to show the elevation warning [Paper] Display elevation warning when creating styles Sep 6, 2020
@eps1lon eps1lon changed the title [Paper] Display elevation warning when creating styles [Paper] Display elevation warning when generating styles Sep 6, 2020
@eps1lon eps1lon changed the title [Paper] Display elevation warning when generating styles [Paper] Display elevation warning when rendering Sep 6, 2020
@nesso-pfl

This comment has been minimized.

Sign in to view
@eps1lon

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari merged commit b78f3fa into mui:next Sep 6, 2020
@oliviertassinari
Copy link
Member

@nesso-pfl It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@nesso-pfl nesso-pfl deleted the use-theme-instead-of-classes branch September 6, 2020 15:51
@eps1lon eps1lon mentioned this pull request Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: Paper This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning "Material-UI: this elevation 1 is not implemented" with disableGeneration to true
4 participants
@nesso-pfl @mui-pr-bot @eps1lon @oliviertassinari