Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] change 'autoComplete' to 'no' #22803

Closed
wants to merge 1 commit into from
Closed

[Autocomplete] change 'autoComplete' to 'no' #22803

wants to merge 1 commit into from

Conversation

LethalPants
Copy link

Fixes #22443: disables chrome autocomplete by setting autoComplete to no in useAutocomplete hook.

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 0cba4ae

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari oliviertassinari changed the title [autocomplete] change 'autoComplete' to 'no' [Autocomplete] change 'autoComplete' to 'no' Sep 29, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 29, 2020

We have tried that in the past (using an invalid value, "disabled" in the case of #18376), it doesn't work.

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Sep 29, 2020
@LethalPants
Copy link
Author

LethalPants commented Sep 29, 2020

I'm not sure what is happening I tried with "off", which didn't turn off the autocomplete(as expected).

image

With autocomplete="no"

image

I also tried autocomplete="chrome-off" as suggested here

image

Note : I am using Windows 10 (19041.508 build) and Chrome Version 85.0.4183.121

Edit : Added Browser and OS version.

@eps1lon
Copy link
Member

eps1lon commented Sep 29, 2020

I'm not sure what is happening I tried with "off", which didn't turn off the autocomplete(as expected).

Please always include browser, OS and device you're using. Since these values are invalid different browser might behave different.

So if something "works" or "doesn't work" then it's important to know where it does.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2020
@oliviertassinari
Copy link
Member

I'm closing as the proposed value is no valid HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable the browser auto complete feature for the Autocomplete component
4 participants