Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Fix types of chainPropTypes #23123

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 18, 2020

Without the fix the new reproduction fail:

Capture d’écran 2020-10-18 à 18 27 27

I have first seen the issue in mui/mui-x#455.

I have used https://github.com/DefinitelyTyped/DefinitelyTyped/blob/47120459d29b508f334db2957c1a962eb193d356/types/airbnb-prop-types/index.d.ts#L44 as inspiration for the solution.

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 18, 2020

No bundle size changes comparing ed7f9db...c78e44e

Generated by 🚫 dangerJS against c78e44e

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@oliviertassinari oliviertassinari merged commit 1fe76fd into mui:next Oct 18, 2020
@oliviertassinari oliviertassinari deleted the fix-types-chain branch October 18, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: utils Specific to the @mui/utils package typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants