[Card] Use flex display for CardHeader.avatar #23169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
added
the
component: card
|
@mordechaim Thanks for spending time on this. Do you have a reproduction of the issue? |
|
This shows the original layout, with flex, and with avatar wrapper without flex. |
oliviertassinari
approved these changes
Oct 19, 2020
|
Btw |
|
@mordechaim It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the avatar is not properly aligned with the title when using an icon (it was fine if I used the Avatar component to wrap the icon). Inspecting the element I noticed the flex properties being set but the display wasn't set to flex. Changing this fixed the issue.