[test] Remove data-mui-test from tests #23498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Nov 13, 2020
| @@ -268,12 +268,12 @@ describe('<DateRangePicker />', () => { | |||
| open | |||
| renderInput={defaultRangeRenderInput} | |||
| onChange={() => {}} | |||
| renderDay={(day) => <div key={String(day)} data-mui-test="renderDayCalled" />} | |||
| renderDay={(day) => <div key={String(day)} data-testid="renderDayCalled" />} | |||
There was a problem hiding this comment.
Only change touching pickers since I didn't need to alter pickers implementation
eps1lon
commented
Nov 13, 2020
| @@ -27,7 +27,7 @@ describe('<Backdrop />', () => { | |||
|
|
|||
| it('should render a backdrop div with content of nested children', () => { | |||
| const { container } = render( | |||
| <Backdrop open className="woofBackdrop"> | |||
There was a problem hiding this comment.
Drive-by removal of unused props
| expect(onClose.callCount).to.equal(0); | ||
| }); | ||
|
|
||
| it('should spread custom props on the modal root node', () => { |
There was a problem hiding this comment.
drive-by removal of a duplicate test (describeConformance covers this case).
| @@ -487,9 +488,11 @@ describe('<Popover />', () => { | |||
| }); | |||
|
|
|||
| expectPopover = (top, left) => { | |||
| expect(popoverEl.style.top).to.equal(`${top}px`); | |||
| expect(popoverEl).toHaveInlineStyle({ | |||
There was a problem hiding this comment.
unrelated refactor while I was working with the test.
oliviertassinari
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only targets /core for now which doesn't need
data-mui-testanymore. We can usedata-testidin tests instead.Part of #23488