Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Prevent layout jumps from img loading in system demo #23504

Merged
merged 3 commits into from
Nov 14, 2020
Merged

[docs] Prevent layout jumps from img loading in system demo #23504

merged 3 commits into from
Nov 14, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 13, 2020

Most likely not the best solution but better than documenting images with layout shiift. That's a gap a dedicated Image component could solve (#22470).

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Nov 13, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 13, 2020 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 9ae269c

@github-actions github-actions bot mentioned this pull request Nov 13, 2020
Closed
oliviertassinari
oliviertassinari reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like without an Image component we can't properly solve this problem

docs/src/pages/system/basics/Demo.js Show resolved Hide resolved
docs/src/pages/system/basics/Demo.js Show resolved Hide resolved
oliviertassinari
oliviertassinari requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|

@eps1lon
Copy link
Member Author

eps1lon commented Nov 14, 2020

I feel like without an Image component we can't properly solve this problem

That's exactly what I was talking about in the PR description. How did you interpret the PR body?

@oliviertassinari oliviertassinari merged commit d9edbd9 into mui:next Nov 14, 2020
@eps1lon eps1lon deleted the docs/img-layoutshift branch June 24, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari