[docs] Add infrastructure to translate API pages #23726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
docs-react-api
branch
3 times, most recently
from
4a1e58d to
b2dcc8c
Compare
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
docs-react-api
branch
from
0ecee03 to
5f02562
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
changed the title
oliviertassinari
requested review from
mbrookes and
eps1lon
and removed request for
mbrookes
eps1lon
requested changes
Nov 26, 2020
There was a problem hiding this comment.
I'm a bit confused about the terminology used for the new components. This looks like it's trying too hard to DRY it out:
- TopLayoutApi
- TopLayoutDocs
- AppLayoutDocs
The linked preview no longer has the feedback UI.
I don't really understand this PR. If it isn't useful on its own then we should extract it. Otherwise we have this piece of code checked-in without purpose.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
PR: out-of-date
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
oliviertassinari
force-pushed
the
docs-react-api
branch
from
5f02562 to
e89e181
Compare
mbrookes
force-pushed
the
docs-react-api
branch
from
11aac59 to
cf0ea42
Compare
mbrookes
force-pushed
the
docs-react-api
branch
from
cf0ea42 to
44a90c8
Compare
github-actions
bot
added
PR: out-of-date
|
@mbrookes I believe it's good to merge now. I would recommend you re-open this pull request with your name, otherwise, the squashed commit might give me the credits. |
oliviertassinari
force-pushed
the
docs-react-api
branch
from
d9de9ec to
1d44586
Compare
oliviertassinari
commented
Dec 5, 2020
Comment on lines
+182
to
+185
| // traverse(pages, 'en'); | ||
| LANGUAGES_SSR.forEach((userLanguage) => { | ||
| traverse(pages, userLanguage); | ||
| }); |
There was a problem hiding this comment.
To revert before we merge:
Suggested change
| // traverse(pages, 'en'); | |
| LANGUAGES_SSR.forEach((userLanguage) => { | |
| traverse(pages, userLanguage); | |
| }); | |
| traverse(pages, 'en'); |
|
Performance seems equivalent between next and this PR: https://www.webpagetest.org/video/compare.php?tests=201205_DiXM_60dc3e9800a353c5cca37c9fddd0e06b,201205_DiTF_12f76403859985b5141587d48a392ef6. |
mbrookes
force-pushed
the
docs-react-api
branch
from
1d44586 to
51816d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #23214 (comment).