[lab] Fix import paths in generated declaration files #24380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is why we write tests: https://github.com/mui-org/material-ui/pull/24380/checks?check_run_id=1687093030 |
oliviertassinari
approved these changes
Jan 12, 2021
|
Going to merge even if we can't confirm the new paths are correct. The paths are definitely incorrect before the change so even if the change does not fix it, we don't make it worse (but code being code I wouldn't be surprised if it did make it worse). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites
import()types frommaterial-ui/srcandmaterial-ui-styles/srcto their corresponding bare imports specifiers (@material-ui/coreand@material-ui/styles).These are hardcoded at the moment to be careful with what we rewrite. I hope that this isn't something we have to maintain long-term.
This PR doesn't confirm that the created paths are correct but we now prevent publishing importing from source by switching #24188 from log to failure.
Changes: https://app.circleci.com/pipelines/github/mui-org/material-ui/33261/workflows/1bdc104f-9827-43bc-b987-2dbeb3e46fbf/jobs/212685/parallel-runs/0/steps/0-112
Closes #24112