[ClickAwayListener] Fix children and onClickAway types
#24565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
feat/ClickAwayListener/typescript
branch
from
36490d9 to
6f10c71
Compare
github-actions
bot
added
PR: out-of-date
eps1lon
commented
Jan 26, 2021
| if ( | ||
| !activatedRef.current || | ||
| !nodeRef.current || | ||
| ('clientX' in event && clickedRootScrollbar(event, doc)) |
There was a problem hiding this comment.
We used to access event.clientX on touch events which don't implement that property. So we would always end up evaluating doc.documentElement.clientWidth < undefined || doc.documentElement.clientHeight < undefined. This always evaluates to false so we can bail out early by checking if we have a MouseEvent.
In the end we're forcing less layout on touch events (no access to element.clientWidth) but check property existence more often. Seems like a good tradeoff considering forcing layout is much more expensive than checking property existence and touch events are usually dispatched on weaker devices e.g. smartphones.
eps1lon
force-pushed
the
feat/ClickAwayListener/typescript
branch
from
e0b93ad to
2980efa
Compare
eps1lon
force-pushed
the
feat/ClickAwayListener/typescript
branch
from
2980efa to
569dcf4
Compare
oliviertassinari
approved these changes
Jan 26, 2021
xs9627
added a commit
to xs9627/material-ui
that referenced
this pull request
Jan 27, 2021
* next: (34 commits) [Tab] Migrate to emotion (mui#24651) [TextField] Migrate Input component to emotion (mui#24638) [ImageList] Migrate ImageListItemBar to emotion (mui#24632) [CircularProgress] Migrate to emotion (mui#24622) [DataTable] Add example in docs for data table (mui#24428) [Card] Migrate CardActionArea to emotion (mui#24636) [core] Fix `next` using stale pages (mui#24635) [List] Migrate ListItemIcon to emotion (mui#24630) [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565) [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644) [Fab] Migrate to emotion (mui#24618) [TextField] Migrate FilledInput to emotion (mui#24634) [Card] Migrate CardHeader to emotion (mui#24626) [Card] Migrate CardMedia to emotion (mui#24625) [ImageList] Migrate ImageListItem to emotion (mui#24619) [website] Add vision block (mui#24603) [docs] Add sorting section (mui#24637) [TextField] Prepare removal of labelWidth prop (mui#24595) [Dialog] Migrate DialogTitle to emotion (mui#24623) [ImageList] Migrate to emotion (mui#24615) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #24564 (diff)
childrenallowed a nullableReactNodewhen we actually treat it as a non-nullableReactElement.onClickAwaywould allow treating the event as a React event when we only pass it a native event.Test plan