[test] Run more tests in Strict Mode #24646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
test-strict-mode
branch
6 times, most recently
from
6c1fb1f to
ef566f3
Compare
oliviertassinari
force-pushed
the
test-strict-mode
branch
from
ef566f3 to
ad8214d
Compare
eps1lon
reviewed
Jan 27, 2021
eps1lon
previously requested changes
Jan 27, 2021
oliviertassinari
dismissed
eps1lon’s stale review
individual strict: false reverted
eps1lon
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have converted as many tests as possible to strict mode. It increases the constraints in the CI
It removes some of the uncertainty of what's left to do (raised in #13394 (comment)).