Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snackbar] Shouldn't be light in dark mode #24704

Closed
wants to merge 2 commits into from
Closed

[Snackbar] Shouldn't be light in dark mode #24704

wants to merge 2 commits into from

Conversation

Renfrew
Copy link
Contributor

@Renfrew Renfrew commented Jan 30, 2021 •
edited by mbrookes
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 30, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against b9f9db0

@mbrookes mbrookes changed the title [Snackbar] Shouldn't be light in dark mode #24438 [Snackbar] Shouldn't be light in dark mode Jan 30, 2021
@mbrookes mbrookes added component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Jan 30, 2021
@mbrookes
Copy link
Member

@Renfrew This change makes the snackbar light in light mode.

@Renfrew
Copy link
Contributor Author

Renfrew commented Jan 30, 2021

@mbrookes Should I keep it dark?

@Renfrew
Copy link
Contributor Author

Renfrew commented Jan 30, 2021

Will push soon

@oliviertassinari
Copy link
Member

It looks like I was wrong. It's fine to have the snackbar light in dark mode: https://material.io/design/color/dark-theme.html#custom-application

Capture d’écran 2021-01-31 à 18 51 34

Capture d’écran 2021-01-31 à 18 51 41

Thanks for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Snackbar] Shouldn't be light in dark mode
4 participants
@Renfrew @mui-pr-bot @mbrookes @oliviertassinari