-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Switch] Make color primary default #26182
Conversation
Let’s update the examples so that we can fix the argos differences. |
@mnajdova The changes of argos I think are expected. Should the demonstrations in the examples show the primary color or secondary? For the ColorSwitches demo, green was corrected. |
Ideally, we shouldn't have changes in argos. We should just do: -<Switch />
+<Switch color="secondary" /> and -<Switch color="primary"/>
+<Switch /> |
I'm not so sure, the idea was that "primary" makes more sense. Would we send a contradicting message if the docs don't use it? |
Co-authored-by: Marija Najdova <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Breaking changes
[Switch] Make
color="primary"
the default over secondary. This better matches the material design guidelines.One of the material design section #20012
Preview: https://deploy-preview-26182--material-ui.netlify.app/components/switches/