Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Switch] Make color primary default #26182

Merged
merged 6 commits into from
May 10, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented May 7, 2021

Breaking changes

  • [Switch] Make color="primary" the default over secondary. This better matches the material design guidelines.

    -<Switch />
    +<Switch color="secondary" />

One of the material design section #20012

Preview: https://deploy-preview-26182--material-ui.netlify.app/components/switches/

@mui-pr-bot
Copy link

mui-pr-bot commented May 7, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 70e1166

@mnajdova
Copy link
Member

mnajdova commented May 7, 2021

Let’s update the examples so that we can fix the argos differences.

@vicasas
Copy link
Member Author

vicasas commented May 7, 2021

@mnajdova The changes of argos I think are expected. Should the demonstrations in the examples show the primary color or secondary?

For the ColorSwitches demo, green was corrected.

@vicasas vicasas added breaking change component: switch This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels May 7, 2021
@mnajdova
Copy link
Member

mnajdova commented May 7, 2021

Ideally, we shouldn't have changes in argos. We should just do:

-<Switch />
+<Switch color="secondary" />

and

-<Switch color="primary"/>
+<Switch  />

@oliviertassinari
Copy link
Member

oliviertassinari commented May 7, 2021

Ideally, we shouldn't have changes in argos. We should just do:

I'm not so sure, the idea was that "primary" makes more sense. Would we send a contradicting message if the docs don't use it?

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova merged commit c829338 into mui:next May 10, 2021
@vicasas vicasas deleted the feature/change-color-switch branch May 10, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: switch This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants