-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectField] new SelectField component #26221
Conversation
Details of bundle changes (experimental) @material-ui/core: parsed: +0.45% , gzip: +0.44% |
This comment has been minimized.
This comment has been minimized.
We have other issues that the We need to discuss what is the plan to introduce this new component. We could first create a Regarding this PR: should it be released first in the lab or putting in the core is acceptable?
The docs generator is linking the |
I would propose we do it iteratively (so move forward with this PR). The main value of this SelectField API (#21782) is to bundle InputLabel + Select + FormHelperText, allowing to have a good tree-shaking when importing the TextField (removing the For the more ambitious fixes on the dropdown, IMHO, we could rewrite from scratch and start from the lab, things we could fix:
I doubt we can make it in time for v5-beta. |
I don't see any value in a new SelectField if it doesn't solve fundamental behavior and API issues with Select.
As shown in the size-comparison, the proposed implementation does not adress this issue.
The new component is part of the core so there is not iterative approach possible. |
Close this issue to implement proper |
Thanks for the exploration! |
An opportunity to understand at the codebase, can't missed it 😊 |
this PR is part of #21782
Summary of this PR
SelectField
to separate select fromTextField
(detail is in the issue above)value
onChange
followSelect
component pattern (use generic since value can be string or array)multiple
,native
at the top ofSelectField
for ease of use.I feel
SelectField
has a better API than using<TextField select
. @oliviertassinariFor removing
select
fromTextField
(breaking change), I think it can be another followup PR?