[docs] Remove last dependencies on makeStyles from @material-ui/core/styles
#26246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
commented
May 11, 2021
| }, | ||
| })); | ||
| }), | ||
| { defaultTheme }, |
There was a problem hiding this comment.
Where the code is not publicly visible on docs, or styles are too complicated, I used the defaultTheme prop.
mnajdova
commented
May 11, 2021
| setChecked(newChecked); | ||
| setExpandPaths(newChecked ? allNodeIds : []); | ||
| onChange={(event) => { | ||
| setChecked(event.target.checked); |
There was a problem hiding this comment.
Oops this was broken in #25871
| twitter: { | ||
| width: 160, | ||
| display: 'flex', | ||
| const Content = styled(Container)(({ theme }) => ({ |
There was a problem hiding this comment.
This page is going away, it would have been simpler to change the import only (it seems).
| @@ -207,7 +207,8 @@ const styles = (theme) => ({ | |||
| }, | |||
| }, | |||
| }); | |||
| const useStyles = makeStyles(styles, { name: 'MarkdownElement', flip: false }); | |||
| const defaultTheme = createTheme(); | |||
There was a problem hiding this comment.
What about the dark mode and RTL toggle?
There was a problem hiding this comment.
I am setting only defaultTheme. If there is a ThemeProvider with different theme it will be picked up. Is there some scenario that is not working?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes last dependencies on
makeStylesfrom@material-ui/core/styles. Next step would be removing this util from the core.