Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] extract button from ListItem to ListItemButton #26446

Merged
merged 44 commits into from
Jun 7, 2021
Merged

[List] extract button from ListItem to ListItemButton #26446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
e4f684d
add wip ListItemButton
siriwatknp May 25, 2021
a0d6928
update lists docs to use ListItemButton
siriwatknp May 25, 2021
41b248b
run proptypes and docs
siriwatknp May 25, 2021
ae4db46
fix typo name
siriwatknp May 25, 2021
f047a2c
minor fix
siriwatknp May 25, 2021
8fb85ca
mark button related prop as deprecated
siriwatknp May 26, 2021
3f46f02
fix description
siriwatknp May 26, 2021
4f385a9
add usage guide to docs
siriwatknp May 26, 2021
83eadf9
add dense note
siriwatknp May 26, 2021
1678d53
Update docs/src/pages/components/lists/lists.md
siriwatknp May 27, 2021
8941802
Merge branch 'next' of https://github.com/mui-org/material-ui into fe…
siriwatknp Jun 3, 2021
43a0f75
add `action` prop and update demos
siriwatknp Jun 3, 2021
aeb3eb3
run proptypes, docs:api, docs:typescript
siriwatknp Jun 3, 2021
4edef7d
add customized demo and theme component props
siriwatknp Jun 3, 2021
4f931d0
update demo
siriwatknp Jun 3, 2021
9c49711
refactor ListItem.d.ts
siriwatknp Jun 3, 2021
6b1e037
add disablePadding prop
siriwatknp Jun 3, 2021
7040bcc
update demo to use disablePadding
siriwatknp Jun 3, 2021
0884aa6
follow disablePadding in List
siriwatknp Jun 3, 2021
36ff3d1
rename `action` to `secondaryAction` due to type conflict with Button…
siriwatknp Jun 3, 2021
fce2d50
minor fix
siriwatknp Jun 3, 2021
7613961
Merge branch 'next' of https://github.com/mui-org/material-ui into fe…
siriwatknp Jun 3, 2021
eb95812
cleanup
siriwatknp Jun 3, 2021
c26f233
Merge branch 'next' of https://github.com/mui-org/material-ui into fe…
siriwatknp Jun 4, 2021
3ee7f40
fix types
siriwatknp Jun 4, 2021
2584c80
fix
siriwatknp Jun 4, 2021
ba68a1b
fix markdown contrast color
siriwatknp Jun 4, 2021
cbf07f6
Update docs/src/pages/components/lists/CustomizedList.tsx
siriwatknp Jun 6, 2021
adda4fe
Update packages/material-ui/src/ListItemButton/listItemButtonClasses.ts
siriwatknp Jun 6, 2021
5cbbb72
Update packages/material-ui/src/ListItemButton/ListItemButton.js
siriwatknp Jun 6, 2021
5c6928f
Update packages/material-ui/src/ListItem/ListItem.js
siriwatknp Jun 6, 2021
b151863
revert the code
siriwatknp Jun 6, 2021
e7cad0a
sort props
siriwatknp Jun 6, 2021
01b7c69
fix li semantic error
siriwatknp Jun 6, 2021
9bf7c49
Merge branch 'feat/list-item-improvement' of github.com:siriwatknp/ma…
siriwatknp Jun 6, 2021
d76b830
run prettier
siriwatknp Jun 6, 2021
002dd5f
run docs:formatted
siriwatknp Jun 6, 2021
c8f8990
run docs:api
siriwatknp Jun 6, 2021
84c3766
fix Inset demo
siriwatknp Jun 6, 2021
0f13f5f
Update packages/material-ui/src/ListItemButton/ListItemButton.js
siriwatknp Jun 7, 2021
6e8431a
Update packages/material-ui/src/ListItemButton/listItemButtonClasses.ts
siriwatknp Jun 7, 2021
4ba8d1c
move role undefined to ListItemButton
siriwatknp Jun 7, 2021
e0bffb4
run docs:api
siriwatknp Jun 7, 2021
0195818
fix as suggested
siriwatknp Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/pages/components/lists/InsetList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ export default function InsetList() {
component="nav"
aria-label="contacts"
>
<ListItem disablePadding>
<ListItem component="div" disablePadding>
<ListItemButton>
<ListItemIcon>
<StarIcon />
</ListItemIcon>
<ListItemText primary="Chelsea Otakan" />
</ListItemButton>
</ListItem>
<ListItem disablePadding>
<ListItem component="div" disablePadding>
<ListItemButton>
<ListItemText inset primary="Eric Hoffman" />
</ListItemButton>
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/lists/InsetList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ export default function InsetList() {
component="nav"
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
aria-label="contacts"
>
<ListItem disablePadding>
<ListItem component="div" disablePadding>
<ListItemButton>
<ListItemIcon>
<StarIcon />
</ListItemIcon>
<ListItemText primary="Chelsea Otakan" />
</ListItemButton>
</ListItem>
<ListItem disablePadding>
<ListItem component="div" disablePadding>
<ListItemButton>
<ListItemText inset primary="Eric Hoffman" />
</ListItemButton>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/lists/VirtualizedList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function renderRow(props) {
const { index, style } = props;

return (
<ListItem style={style} key={index} disablePadding>
<ListItem style={style} key={index} component="div" disablePadding>
<ListItemButton>
<ListItemText primary={`Item ${index + 1}`} />
</ListItemButton>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/lists/VirtualizedList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function renderRow(props: ListChildComponentProps) {
const { index, style } = props;

return (
<ListItem style={style} key={index} disablePadding>
<ListItem style={style} key={index} component="div" disablePadding>
<ListItemButton>
<ListItemText primary={`Item ${index + 1}`} />
</ListItemButton>
Expand Down