Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimePicker] Follow Tabs change #26663

Closed
wants to merge 1 commit into from
Closed

[DateTimePicker] Follow Tabs change #26663

wants to merge 1 commit into from

Conversation

watiko
Copy link

@watiko watiko commented Jun 9, 2021

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 9, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 2740db4

@eps1lon eps1lon added bug 🐛 Something doesn't work component: date time picker This is the name of the generic UI component, not the React module! labels Jun 9, 2021
eps1lon
eps1lon approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Visual regression test show niceley what's being fixed.

@watiko
Copy link
Author

watiko commented Jun 9, 2021

Sorry I couldn't find #26283 and #26624 may be better solution for this.

@eps1lon
Copy link
Member

eps1lon commented Jun 9, 2021

Sorry I couldn't find #26283 and #26624 may be better solution for this.

Why do you think that?

@watiko
Copy link
Author

watiko commented Jun 9, 2021 •
edited
Loading

I thought it was better than the small fixes I made, because it solves the problem of the icons not being visible , of couse this PR solves it too, and also includes improvements to make them more visible.

If you don't see a problem, don't worry about merging it.

@eps1lon
Copy link
Member

eps1lon commented Jun 10, 2021

I thought it was better than the small fixes I made, because it solves the problem of the icons not being visible , of couse this PR solves it too, and also includes improvements to make them more visible.

Thanks for the clarification

@eps1lon eps1lon closed this Jun 10, 2021
@watiko watiko deleted the fix/date-time-picker-tab-color branch June 10, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: date time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watiko @mui-pr-bot @eps1lon