Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Fix demo to have correct semantic #26742

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[List] Fix demo to have correct semantic #26742

merged 2 commits into from
Jun 15, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 14, 2021 •
edited by oliviertassinari
Loading

@siriwatknp siriwatknp changed the title [List] fix simple list demo to have correct semantic [List] fix demo to have correct semantic Jun 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 14, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 5211ef0

oliviertassinari
oliviertassinari reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are on this demo, we might as well rename the header to match the other pages "## Basic list"?

@oliviertassinari oliviertassinari added component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Jun 14, 2021
@siriwatknp
Copy link
Member Author

If we are on this demo, we might as well rename the header to match the other pages "## Basic list"?

sure, no strong opinion.

@siriwatknp siriwatknp merged commit f5ff015 into mui:next Jun 15, 2021
@siriwatknp siriwatknp deleted the fix/lists-demo branch June 15, 2021 05:51
@oliviertassinari oliviertassinari changed the title [List] fix demo to have correct semantic [List] Fix demo to have correct semantic Jun 15, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 15, 2021 •
edited
Loading

Thanks for the follow-up 👍

I have changed the title with an upper case F to match the existing arbitrary title convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova