[Dialog] Automatically label by its DialogTitle #26814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
accessibility
eps1lon
changed the title
| @@ -225,6 +227,11 @@ const Dialog = React.forwardRef(function Dialog(inProps, ref) { | |||
| } | |||
| }; | |||
|
|
|||
| const ariaLabelledby = useId(ariaLabelledbyProp); | |||
There was a problem hiding this comment.
What's the story for dialogs that don't render a <DialogTitle>? For instance https://next.material-ui.com/components/dialogs/#full-screen-dialogs.
Does an aria-labelledby pointing to a nonexisting DOM node create an a11y issue?
There was a problem hiding this comment.
What's the story for dialogs that don't render a ?
They are already problematic.
Does an aria-labelledby pointing to a non existing DOM node an a11y issue?
Nope. It will be treated just like it has no aria-labelledby
There was a problem hiding this comment.
Nope. It will be treated just like it has no aria-labelledby
Great, and we even have the optionality to have DialogContent host the label` if needed, in the future.
oliviertassinari
approved these changes
Jun 21, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to manually wire up Dialog and DialogTitle
Instead of
you can write
instead which automatically labels the
role="dialog"with the contents ofDialogTitle.