[TextField] Remove ref prop on text field #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an anti pattern. It's not possible to pass ref down inot the component. So having it as a prop is useless and will prevent refrencing the component.
|
@alitaheri Yeah, let's get ride of this |
alitaheri
added a commit
that referenced
this pull request
Dec 29, 2015
[TextField] Remove ref prop on text field
|
@oliviertassinari Thanks 👍 🎉 |
zannager
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an anti pattern. It's not possible to pass ref down inot the component. So having it as a prop is useless and will prevent refrencing the component.
Closes #2699
@oliviertassinari Please review