-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Markdown redesign polish #27956
Conversation
This comment has been minimized.
This comment has been minimized.
@danilo-leal sometimes some of the docs component are being rendered as part of the Demos (note that in that case they have the Material Design theme available, no the branding). This is why sometimes you were seeing errors that @siriwatknp I've also updated how the new theme is created, no need to invoke two times |
This comment has been minimized.
This comment has been minimized.
I have pushed small commits trying to simplify and fix more issues, for instance, we were using a font that we don't load, and since loading extra fonts comes with a cost, I defaulted to using the existing ones. @danilo-leal I think that some of these changes could be used as a review of the changes. The last thing I could notice is the lack of nested side nav. We need it for the date picker, and soon for scaling the content of the data grid. The regression: |
This comment has been minimized.
This comment has been minimized.
@@ -81,7 +81,7 @@ const Root = styled('div')(({ theme }) => ({ | |||
'& h3': { | |||
...theme.typography.h6, | |||
margin: '20px 0 10px', | |||
fontFamily: ['"PlusJakartaSans-Bold"'].join(','), | |||
fontFamily: ['"PlusJakartaSans-ExtraBold"'].join(','), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliviertassinari Any idea on how we can use the bold weight? It hurts the heading hierarchy a bit having the h3 styling be extra-bold too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can ask @siriwatknp. He seems to have been iterating multiple times on the best way to load custom fonts.
For context, I noticed it loading the page in BrowserStack in a Windows 10 machine, where this font-weight is not installed by default. The header had the default user-agent font, not pretty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add the bold weight.
Great point about the nested Date/Time. I tried to tackle it myself but couldn't pull it off. @mnajdova or @siriwatknp could definitely pull it off easily. I think maybe something like this works for the time being: having the |
How should we handle the component sub-section reorder? I can add a commit to this PR per the Figma proposal, or submit a PR to the PR for further discussion... |
@mnajdova @oliviertassinari @mbrookes @danilo-leal What do you think if we merge the current progress so that it goes with this week release and then create another PR for what's left? |
Sounds good, I will merge this after the package rename, and then we can do the release. |
@danilo-leal maybe we can move the language at the end (after the settings button)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo code is readable again, thanks 👍🏻
Opening early so that we can iterate with @danilo-leal
Preview link: https://deploy-preview-27956--material-ui.netlify.app/