Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix CONTRIBUTING to point out to master as targeted branch #28396

Merged
merged 3 commits into from
Sep 20, 2021
Merged

[docs] Fix CONTRIBUTING to point out to master as targeted branch #28396

merged 3 commits into from
Sep 20, 2021

Conversation

mnajdova
Copy link
Member

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 17, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 20edeb5

eps1lon
eps1lon requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these things it's vital to add the #default-branch-switch to avoid doing the same mistake over and over again. Don't just focus on the fix. Try to make it so that the mistake can be avoided in the future entirely.

@mnajdova
Copy link
Member Author

For these things it's vital to add the #default-branch-switch to avoid doing the same mistake over and over again. Don't just focus on the fix. Try to make it so that the mistake can be avoided in the future entirely.

Done 👍

@mnajdova mnajdova requested a review from eps1lon September 17, 2021 08:34
@mnajdova mnajdova merged commit 181c842 into mui:master Sep 20, 2021
@zannager zannager added the docs Improvements or additions to the documentation label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnajdova @mui-pr-bot @eps1lon @zannager