[website] Close the open engineering roles #28428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
website
oliviertassinari
force-pushed
the
focus-on-product
branch
from
4f10391 to
ec051a7
Compare
eps1lon
reviewed
Sep 19, 2021
docs/pages/careers.tsx
Outdated
| )} | ||
| </React.Fragment> | ||
| ))} | ||
| {Object.values(openRolesData).map((category) => { |
There was a problem hiding this comment.
Looks like you never use their keys so you might as well use an array to ensure IE11 compat. Bad look in general if people audit IE11 compat.
There was a problem hiding this comment.
Yeah ok, we don't need an object, an array is good enough, and will better scale if we move to a CMS, I'm updating.
I have just tried on BrowserStack, all the pages are broken on http://mui.com/, docs included with IE 11. I would vote for ignoring it.
siriwatknp
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-28428--material-ui.netlify.app/careers/
The PR started with a straightforward objective: to close the open engineering roles. We have done enough. Time to focus on the product.
Bonus:
Stack dividerfeature, such a time saver! At some point, I think that we should push this to a CMS. It's frustrating/slow to have to open a PR to change the content.