-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add missing justifyContent
values and update box styling
#29117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siriwatknp Sure I can do that but I made the change because @oliviertassinari mentioned it in the original issue #29050 It would perhaps make sense to go ahead and make all the boxes on the flexbox page look like how the boxes on the grid page look. I can make this change as part of this PR (if you're okay with it) or just revert back to the gray ones for now. Will wait for your confirmation. |
@omarmosid Thanks for pointing that out. I think all of the boxes in grey can be converted to blue (similar to grid demos) in this PR! please go ahead with blue boxes. BTW, Nice work! |
…, alignSelf, display, flexDirection, flexGrow, flexShrink, flexWrap, and Order and update box item styling
Thankyou for the feedback @siriwatknp. I have now updated the PR and added a few missing examples for css properties that can be used for I have also taken the liberty to add links to the relevent MDN documentation under each property title. Hope that's going to be okay. It's worth noting here that these links open in the same page since they are your normal markdown links and we may want to have them open in a new tab. So I could change: For more information please see [flex-direction](https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction) on MDN. with For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction" target="_blank" rel="noopener noreferrer">flex-direction</a>
on MDN. Again will wait for your confirmation, before making this change. |
Sounds good to me, please go ahead. |
@omarmosid If you don't mind, I would like to reduce the font-size from |
No problem at all. Please feel free to let me know in case any more changes are needed 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice work. Thanks for your first contribution and welcome to MUI community!
justifyContent
values and update box styling
Closes: #29050