Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Fix return type of createBox #29989

Merged
merged 3 commits into from
Dec 2, 2021
Merged

[system] Fix return type of createBox #29989

merged 3 commits into from
Dec 2, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Dec 1, 2021

Fixes #29978

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 1, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 2f1ba1b

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2021
@mnajdova mnajdova marked this pull request as ready for review December 1, 2021 11:26
@mnajdova mnajdova requested a review from siriwatknp December 1, 2021 11:26
@mnajdova mnajdova added package: system Specific to @mui/system typescript labels Dec 1, 2021
siriwatknp
siriwatknp approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

need to keep an eye on the dependency cycle in the future.

@mnajdova
Copy link
Member Author

mnajdova commented Dec 2, 2021

need to keep an eye on the dependency cycle in the future.

Was thinking about the same thing, but it works for now.

@mnajdova mnajdova merged commit 122252e into mui:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
package: system Specific to @mui/system typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createBox and Box from @mui/system return different types.
3 participants
@mnajdova @mui-pr-bot @siriwatknp