[base] Fix missing ClickAwayListener barrel index export #30000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
A side thought, is this description still accurate?
Shouldn't we say the "base package"? (x all the other instances) |
|
If you can upvote my SO answer, it might help as well 🙏 . All the opportunities are good to attract new users 😁 |
oliviertassinari
changed the title
|
@material-ui/unstyled: parsed: +1.69% , gzip: +1.53% |
oliviertassinari
force-pushed
the
export-base-ClickAwayListener
branch
from
bab330f to
6ccc9ff
Compare
oliviertassinari
force-pushed
the
export-base-ClickAwayListener
branch
from
6ccc9ff to
5ba2828
Compare
Yes, good point. Adding to my todo list. |
michaldudak
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to update https://stackoverflow.com/questions/32553158/detect-click-outside-react-component/59913572#59913572 to point to https://mui.com/components/click-away-listener/#unstyled which claims to have a smaller bundle size. But unfortunately, I couldn't find it in https://bundlephobia.com/package/@mui/[email protected]. Turns out, it wasn't exported from the barrel index. I have used this opportunity to reorder alphabetically the exports.