[core] Fixes error in changelog generator for item sorting/padding #30088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just happened to notice this. consider if there were 10 items. That means `Math.log10(10)`, will evaluate to `1`. Then `Math.ceil(1)` evaluates to `1`, then `'9'.padStart(1, '0')` evaluates to `'9'` when it is intended to evaluate to `'09'` because there are 10 items.
eps1lon
changed the title
eps1lon
reviewed
Dec 7, 2021
Co-authored-by: Sebastian Silbermann <[email protected]>
mnajdova
approved these changes
Mar 23, 2022
|
oh yeah. @eps1lon @oliviertassinari @mnajdova (not sure who else would care) in case it's of any interest to you, my looking into your changelog generator ended up turning into https://github.com/Kong/changelog-generator which is being used at a few teams at Kong now (including Insomnia). There's 100% test coverage. Although the functionality diverged quite a bit, the end result is close-ish to what you all do. Just thought I'd share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just happened to notice this. consider if there were 10 items. That means
Math.log10(10), will evaluate to1. ThenMath.ceil(1)evaluates to1, then'9'.padStart(1, '0')evaluates to'9'when it is intended to evaluate to'09'because there are 10 items. This will then happen 10% of the time.(not entirely sure what the right format for the PR title is for this)