-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drawer] Adjustments to the mini variant to improve UI/UX #30205
Conversation
Hey! Thanks for contributing :) Although I like that on your proposal the drawer icons are now aligned with the hamburger menu icon + the spacing is symmetrical, the changes added a flick whenever opening/closing the drawer, which didn't happen previously (videos attached below). So, if you're willing to try, I guess we could explore finding out an approach to have the alignment+spacing adjusted without introducing the flickering. drawer-before.movdrawer-after.mov |
@danilo-leal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I used the mini-drawer variant with some pain at first :). It needed some adjustments to make it look and behave as you want it to be; for the adjusted mini-drawer to work, your screen size requires >= 'MD.' I can not provide a link to a demo or video but how it works within an app; maybe this helps. Link to the demo: https://millipede.me/docs/perspective/strategy Thx! |
👋 The migration PR has been merged. Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)
If you are struggle with the steps above, feel free to tag @siriwatknp |
Closed this PR (I can't update @devzgabriel's branch) and open another one with the fix) |
Deploy preview: https://deploy-preview-30205--material-ui.netlify.app/components/drawers/#mini-variant-drawer