-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar] Fix TypeScript error on imgProps #30255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add test to verify we won't break it again in the future. You can add a file in the same folder as the component, named Avatar.spec.tsx
, with this code:
import * as React from 'react';
import Avatar from '@mui/material/Avatar';
function ImgPropsShouldSupportSx() {
<Avatar imgProps={{ sx: { objectFit: "contain" }}} />;
}
uhh sorry, i was using github.dev, i will work on this once i'm at home |
So, I've tried running yarn prettier as suggested in the CI but nothing changed, so I confused about what to do at this point |
Not sure why you didn't see any changes. I've run and committed them. Should be good to go now. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Ok thanks 😄 |
This pr will close Wrong propType for <Avatar imgProps={} /> #30238