Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Introducing the Row Grouping feature #30598

Merged
merged 14 commits into from
Jan 21, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jan 13, 2022

@mui-bot
Copy link

mui-bot commented Jan 13, 2022

No bundle size changes

Generated by 🚫 dangerJS against 5e8003f

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !
My review is mainly rephrasing things, the content is very nice.

An example with an initial grouping model may be interesting.
To have something like

  1. You can show the data to the user grouped in the way you want
  2. But the user can also choose there own grouping criteria, they are not limited by what you prepared
  3. You can limit the grouping criteria because some don't make sense

@oliviertassinari
Copy link
Member

The slug of the post is /mui-x-v5.3.0. Should we rename the title not to be "Introducing Row Grouping Feature" but "MUI X v5.3.0"?

@alexfauquette
Copy link
Member Author

@oliviertassinari Probably renaming the slug "row-grouping-introduction" would make more sense from an SEO point of view because it adds keywords to the URL

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 18, 2022

@alexfauquette If we don't extend this blog post to turn it into a release blog post, then I agree, it would make more sense. I wouldn't do it so much for SEO, because I expect that the docs pages will always rank before it, but to be clearer about the content 😁.

At the high level, I think that this blog post could benefit from more links. I imagine that we can link the release GitHub page, the docs for the grouping, and maybe a link to a codesandbox to play with the source of the video demos. Otherwise, the content is very clean and clear 👌, it remembers me Danilo's great writing style, with the upside of being information denser.

@oliviertassinari oliviertassinari changed the title [blog] article for X release v5.3 [blog] Introducing Row Grouping Feature Jan 18, 2022
@oliviertassinari oliviertassinari changed the title [blog] Introducing Row Grouping Feature [blog] Introducing the Row Grouping feature Jan 20, 2022
@alexfauquette alexfauquette merged commit a7f8de8 into mui:master Jan 21, 2022
@alexfauquette alexfauquette deleted the blog-mui-x-v5.3 branch January 21, 2022 14:27
@siriwatknp siriwatknp mentioned this pull request Jan 21, 2022
1 task
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Siriwat K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants