-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatePicker] Fix passing clearable prop #30786
[DatePicker] Fix passing clearable prop #30786
Conversation
@material-ui/lab: parsed: +0.12% , gzip: -0.01% 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we are currently moving the pickers in https://github.com/mui-org/material-ui-x so I would propose focusing on some other components at the time being, until the migration settles. The changes for this particular PR look good, only some polish is needed
Thanks for the comments @mnajdova. I will work on them |
0659e00
to
a4f3df7
Compare
👋 The migration PR has been merged. Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)
If you are struggle with the steps above, feel free to tag @siriwatknp |
aadd994
to
821a0f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @alisasanib
@flaviendelangle FYI |
DateRangePicker |
clearable not showing clear button on mobile components |
Hi, Could you provide a working reproduction, this Codesandbox template might be a good starting point. |
We changed the way users can customize the actions on the pickers Here is your example updated: https://codesandbox.io/s/date-and-time-pickers-forked-j1swd3?file=/src/App.tsx By the way, I don't think our components ever had an |
Fixes: [DatePicker] 'clearable' prop has no effect. #30676
Demo
Problems:
Solution: