[Grid] Fix columns of nested container #31340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutahlilsoufiane
changed the title
boutahlilsoufiane
changed the title
danilo-leal
changed the title
michaldudak
approved these changes
Mar 10, 2022
|
Hi @michaldudak, thanks a lot. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30209.
This fixes the problem of giving a grid item within a nested grid container the wrong
width. I think the source of the problem is the grid container inherits thecolumnsof the root container and this happens only in the case when the propcolumnsvalue is 12. I tried to use the defaultcolumnsvalue which’s 12.