Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix y-axis unit used in the responsive font sizes chart #31424

Merged
merged 1 commit into from
Mar 12, 2022
Merged

[docs] Fix y-axis unit used in the responsive font sizes chart #31424

merged 1 commit into from
Mar 12, 2022

Conversation

aaarichter
Copy link
Contributor

Changes

  • update unit from rem to px in displayed responsive font-sizes chart

before:
Values shown in the chart are in px same as y-axis scale. But y-axis says rem instead of px
Bildschirmfoto 2022-03-11 um 20 16 55

after:
Bildschirmfoto 2022-03-11 um 20 25 44

@mui-bot
Copy link

mui-bot commented Mar 11, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 3d5ebc2

@danilo-leal danilo-leal changed the title fix(ResponsiveFontSizesChart): change displayed unit on y-axis [docs] Update y-axis unit used in the Responsive Font Sizes Chart Mar 11, 2022
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 11, 2022
@oliviertassinari oliviertassinari changed the title [docs] Update y-axis unit used in the Responsive Font Sizes Chart [docs] Fix y-axis unit used in the Responsive Font Sizes Chart Mar 12, 2022
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Typography The React component. labels Mar 12, 2022
@oliviertassinari oliviertassinari changed the title [docs] Fix y-axis unit used in the Responsive Font Sizes Chart [docs] Fix y-axis unit used in the responsive font sizes chart Mar 12, 2022
@oliviertassinari oliviertassinari merged commit fa03dbd into mui:master Mar 12, 2022
@oliviertassinari
Copy link
Member

@aaarichter It's a great first pull request on MUI 👌🏻. Thank you for working on it!

@aaarichter aaarichter deleted the fix-responsivefontsizechart branch March 12, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Typography The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaarichter @mui-bot @oliviertassinari @danilo-leal