Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Support horizontal List #31620

Merged
merged 3 commits into from
Mar 14, 2022
Merged

[Joy] Support horizontal List #31620

merged 3 commits into from
Mar 14, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 13, 2022

🖥 Preview

Prepare for the menu components (menubar).

Changes

  • add row prop to List component which passes to React context.
  • ListItem, ListItemButton, and ListDivider listen to the context and adjust the styles according to the direction of the parent list.

Note: the context is not nestable which makes sense because the nested row is not common.

Screen Shot 2565-03-14 at 10 51 31


@siriwatknp siriwatknp added the package: joy-ui Specific to @mui/joy label Mar 13, 2022
@mui-bot
Copy link

mui-bot commented Mar 13, 2022

Details of bundle changes

@mui/joy: parsed: +0.55% , gzip: +0.53%

Generated by 🚫 dangerJS against 9d37ca0

@siriwatknp siriwatknp marked this pull request as ready for review March 14, 2022 03:52
@siriwatknp siriwatknp requested a review from danilo-leal March 14, 2022 03:53
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds perfect!

@siriwatknp siriwatknp merged commit 78c0689 into mui:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants