-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Base ClickAwayListener style revisions and final review #32156
[docs] Base ClickAwayListener style revisions and final review #32156
Conversation
docs/data/base/components/click-away-listener/click-away-listener.md
Outdated
Show resolved
Hide resolved
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two minor issues. Besides that it looks good!
docs/data/base/components/click-away-listener/click-away-listener.md
Outdated
Show resolved
Hide resolved
docs/data/base/components/click-away-listener/click-away-listener.md
Outdated
Show resolved
Hide resolved
…ner.md Co-authored-by: Michał Dudak <[email protected]>
…ner.md Co-authored-by: Michał Dudak <[email protected]>
@@ -1,58 +1,64 @@ | |||
--- | |||
product: base | |||
title: Detect click outside React component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title was on purpose for SEO. See https://stackoverflow.com/questions/32553158/detect-click-outside-react-component for why. Sure it might not be for the title but we still need to rank for this search intent:
I have updated https://stackoverflow.com/a/59913572/2801714 to point to the latest URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert this title in the final pass of the Base docs. I'll make a note of it.
|
||
```tsx | ||
<ClickAwayListener> | ||
<div role="presentation"> | ||
<h1>non-interactive heading</h1> | ||
</div> | ||
</ClickAwayListern> | ||
</ClickAwayListener> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general note, it can be great to search for other instances of the problem in the codebase. It's not rare to have the problem not isolated e.g. #33813 😁.
This PR reviews the
ClickAwayListener
doc. I've done some style editing, and also elaborated on parts of the text that were a bit sparse. I have a couple questions about the content that I will ask as comments on the doc.