Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Base Form Control style revisions and final review #32309

Merged
merged 3 commits into from
Apr 18, 2022
Merged

[docs] Base Form Control style revisions and final review #32309

merged 3 commits into from
Apr 18, 2022

Conversation

mapache-salvaje
Copy link
Contributor

@mapache-salvaje mapache-salvaje commented Apr 14, 2022

This PR implements the style guide on the FormControlUnstyled doc. This one is pretty straightforward—I don't see any clarifications needed.

https://deploy-preview-32309--material-ui.netlify.app/base/react-form-control/

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation component: FormControl The React component package: base-ui Specific to @mui/base labels Apr 14, 2022
@mui-bot
Copy link

mui-bot commented Apr 14, 2022

No bundle size changes

Generated by 🚫 dangerJS against 98d67ca

@mapache-salvaje mapache-salvaje requested a review from a team April 14, 2022 21:19
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnajdova
Copy link
Member

@samuelsycamore should we merge #32134 first?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 18, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 18, 2022
@hbjORbj hbjORbj merged commit 3a68a9c into mui:master Apr 18, 2022
@mapache-salvaje mapache-salvaje deleted the base-form-control-style-review branch April 18, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FormControl The React component docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants