Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableSortLabel]: Add support for CSS vars #32616

Merged
merged 2 commits into from
May 4, 2022
Merged

[TableSortLabel]: Add support for CSS vars #32616

merged 2 commits into from
May 4, 2022

Conversation

haneenmahd
Copy link
Contributor

Add support for CSS variables for the component TableSortLabel component
(#32049).

@mui-bot
Copy link

mui-bot commented May 4, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 3b66f96

@samuelsycamore samuelsycamore added the new feature New feature or request label May 4, 2022
siriwatknp
siriwatknp approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Please fix the failed CI.

@haneenmahd
Copy link
Contributor Author

Will the CI fail if the code is not formatted?

@siriwatknp
Copy link
Member

Code Sandbox error is not related to this PR. It is safe to be merged.

@siriwatknp siriwatknp merged commit 414c2ad into mui:master May 4, 2022
@siriwatknp siriwatknp added the component: table This is the name of the generic UI component, not the React module! label May 4, 2022
@siriwatknp
Copy link
Member

Will the CI fail if the code is not formatted?

Yes, you have to always run yarn prettier before pushing the code.

@haneenmahd
Copy link
Contributor Author

haneenmahd commented May 5, 2022 •
edited
Loading

How about we add git hooks using husky?

@haneenmahd haneenmahd deleted the new-contrib branch May 5, 2022 00:06
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request May 5, 2022
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haneenmahd @mui-bot @siriwatknp @samuelsycamore