[StepIcon] Fix text centering when changing browser font size #32706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
danilo-leal
added
the
component: stepper
mnajdova
requested changes
May 18, 2022
There was a problem hiding this comment.
I could verify that it works 👍 Let's add a regression test to ensure that it won't break in the future. You can follow the examples in https://github.com/mui/material-ui/tree/master/test/regressions/fixtures You can use the GlobalStyles component for injecting: html { font-size: 24px; } as an example.
|
Great! thanks for your review. Is there documentation on how to write tests for this? I don't fully understand how these fixtures are being tested (I see no assertions). |
|
Nevermind, It looks like you are using Playwright to take screenshots |
alansouzati
force-pushed
the
asouza/stepper
branch
from
7c4d5cf to
6022d11
Compare
github-actions
bot
added
the
PR: out-of-date
alansouzati
force-pushed
the
asouza/stepper
branch
from
6022d11 to
e135e69
Compare
github-actions
bot
removed
the
PR: out-of-date
alansouzati
force-pushed
the
asouza/stepper
branch
from
e135e69 to
854d664
Compare
|
This should be ready to go |
alansouzati
force-pushed
the
asouza/stepper
branch
from
854d664 to
ed8311f
Compare
mnajdova
approved these changes
Jun 8, 2022
|
you bet looking forward to more contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changed the StepIcon in a backwards compatible way to fix the centering of the text if you change your browser font size
What you need to test
Before
Text is NOT centered
After
Text is centered