[TablePaginationUnstyled] Define ownerState and slot props' types #32905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
typescript
package: base-ui
mnajdova
reviewed
May 26, 2022
| }, | ||
| "name": null | ||
| }, | ||
| "styles": { "classes": [], "globalClasses": {}, "name": null }, |
There was a problem hiding this comment.
Do we need to find a new way of how to document the global classes for the unstyled components?
There was a problem hiding this comment.
Yes, since the unstyled components don't have the classes prop, we'll have to figure out something else. Perhaps the solution will appear when we allow customizing/disabling the default classes.
| return <div data-rows-per-page={ownerState.rowsPerPage} {...other} />; | ||
| } | ||
|
|
||
| function Button(props: TablePaginationActionsUnstyledButtonSlotProps) { |
mnajdova
approved these changes
Jun 2, 2022
| <NextButton | ||
| onClick={handleNextButtonClick} | ||
| disabled={count !== -1 ? page >= Math.ceil(count / rowsPerPage) - 1 : false} | ||
| color="inherit" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined types for TablePaginationUnstyledownerState and its slots.
Also renamed types and files according to #31415