[Popover] Fix missing type export getOffsetTop
& getOffsetLeft
#32959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering if there's a reason why
getOffsetTop
andgetOffsetLeft
aren't exported from the index? They're actually exported from the mainPopover.js
file but not from the index or typings. Almost seems like a miss.We've found use for these when programmatically supplying a position to the Popover component (i.e.
anchorReference: 'anchorPosition'
andanchorPostion: { top, left }
).To use them, we have to ts-ignore the line due to the lack of typings and import from the 4th level which is meant to be private.
It'd be nice to have them public