[core] Prepare Next.js config for React 18 #32963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, what happens if we don't do it? |
|
When the config is running in the Edge runtime context, the webpack externals are quite different from what we expect (they're in the shape of |
michaldudak
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js introduced another runtime when ran with React 18 (https://nextjs.org/docs/advanced-features/react-18/switchable-runtime). Even when the Edge runtime is not enabled, Next executes the config in the context of it, causing problems with our webpack externals check.
This PR adds a guard to run our checks only on Node runtime. It is backwards compatible with React 17.