[Link] Add support for CSS variables #33036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
new feature
siriwatknp
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
👍 Thanks for kicking off the PR. I have updated the logic in a new file with test cases.
cc @mnajdova for final review.
siriwatknp
reviewed
Jun 7, 2022
| @@ -13,3 +13,4 @@ export interface StyleOptions<PropKey> { | |||
| export function style<PropKey extends string, Theme extends object>( | |||
| options: StyleOptions<PropKey>, | |||
| ): StyleFunction<{ [K in PropKey]?: unknown } & { theme?: Theme }> & { filterProps: string[] }; | |||
| export function getPath<T>(obj: T, path: string | undefined, checkVars?: boolean): null | unknown; | |||
There was a problem hiding this comment.
When I tried to import the function in typescript, it could not find the typings so I added it here.
siriwatknp
reviewed
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Linkcomponent usesalphafor color manipulation and will throw an errorUnsupported `var(--md-palette-primary-main)` colorwhen the experimental CSS Variable API is enabled, but it is not listed in #32049.This PR follows the patterns described in #32049 in order to support CSS variables and fixes this issue.
Preview: https://deploy-preview-33036--material-ui.netlify.app/experiments/material-ui/link/