-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add notification for Joy blog post #33059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just refining it up! Let's wait for Sam's review and the tweets to go up to merge this one!
Also, kinda (but maybe not that much) off-topic, we might need to think about a max number of notifications we want to have in the docs (that scrollbar is getting long!). I'm feeling like 3 is a good number, but maybe even less?! In that sense, should we remove the ones that are there pilling up below the container's fold? |
3 makes sense to me. 👍 |
@danilo-leal Are we good to merge this PR? |
Not quite yet, I'd say! The notification is up at the moment we merge it, right? We should wait for the tweet—it'll be up today (Wednesday) or Thursday tops. |
Yes, that's right.
Got it. |
This PR should be merged after the release of the blog post.