Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputBase: change onInvalid handler to use HTMLInputElement | HTMLTextAreaElement Element type #33162

Merged
merged 3 commits into from
Oct 25, 2022
Merged

InputBase: change onInvalid handler to use HTMLInputElement | HTMLTextAreaElement Element type #33162

merged 3 commits into from
Oct 25, 2022

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Jun 15, 2022 •
edited
Loading

Hi, I was forced to cast onInvalid handler to React.FormEventHandler<HTMLDivElement> to please tsc.
This shouldn't be the case as it is applied to the inner InputComponent

regards,
Nicolas Le Cam

@mui-bot
Copy link

mui-bot commented Jun 15, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-33162--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 9269f53

@michaldudak
Copy link
Member

Could you please open an issue and provide reproduction steps (or, even better, a minimal repro on CodeSandbox) for the problem this PR solves?

@michaldudak michaldudak added component: text field This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information package: material-ui Specific to @mui/material labels Oct 12, 2022
@KuSh
Copy link
Contributor Author

KuSh commented Oct 13, 2022 •
edited
Loading

Could you please open an issue and provide reproduction steps (or, even better, a minimal repro on CodeSandbox) for the problem this PR solves?

Sure, created #34753 with repro case

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Oct 13, 2022
@KuSh KuSh mentioned this pull request Oct 13, 2022
Closed
2 tasks
@michaldudak
Copy link
Member

Thanks! The implementation looks good.
Could you please create an InputBase.spec.tsx file testing the implementation (see Link.spec.tsx to see how it should look like)?

@KuSh
Copy link
Contributor Author

KuSh commented Oct 15, 2022 •
edited
Loading

Sure here it is @michaldudak !

@michaldudak
Copy link
Member

Great, one more thing to do would be to merge in the latest master. It should solve the issue with the failing regression tests.

@KuSh
Copy link
Contributor Author

KuSh commented Oct 19, 2022 •
edited
Loading

Great, one more thing to do would be to merge in the latest master. It should solve the issue with the failing regression tests.

Rebased on mui:master

michaldudak
michaldudak approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks for your work!

@siriwatknp siriwatknp merged commit 4f90054 into mui:master Oct 25, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@KuSh
[InputBase] Fix onInvalid to use HTMLInputElement | HTMLTextAreaEle…
65b0e15 
…ment Element type (mui#33162)
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@KuSh
[InputBase] Fix onInvalid to use HTMLInputElement | HTMLTextAreaEle…
7122e7e 
…ment Element type (mui#33162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KuSh @mui-bot @michaldudak @siriwatknp