-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack] Ensure that marginundefined
doesn't occur in styling
#33548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
added
bug 🐛
Something doesn't work
package: material-ui
Specific to @mui/material
component: Stack
The React component.
labels
Jul 17, 2022
2 tasks
mnajdova
reviewed
Jul 18, 2022
mnajdova
reviewed
Jul 19, 2022
mnajdova
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hbjORbj
force-pushed
the
fix/stack-direction-prop
branch
from
July 19, 2022 15:52
7d49ca8
to
f4d3d6f
Compare
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: Stack
The React component.
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32196
Problem:
direction
prop receives a responsive value such that it doesn't start with the smallest breakpoint, such asdirection={{ lg: 'row' }}
, for the breakpoints belowlg
,"marginundefined": "0px"
is being used in styling instead of"marginLeft": "0px"
(forrow
direction) or"marginTop": "0px"
(forcolumn
direction).undefined
becausedirectionValues[breakpoint]
in the next line, line 87, isundefined
.Solution:
undefined
, by ensuring thatdirectionValues[breakpoint]
in the next line, line 87, is notundefined
.Codesandboxes:
Before
After