[blog] Improve the width of the layout #33706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,4 +305,4 @@ if (process.env.NODE_ENV !== 'production') { | |||
| TopLayoutBlog.propTypes = exactProp(TopLayoutBlog.propTypes); | |||
| } | |||
|
|
|||
| export default styled(TopLayoutBlog)(styles); | |||
| export default TopLayoutBlog; | |||
There was a problem hiding this comment.
The BrandingProvider theme was not applied at this point yet. theme.spacing would be 8 vs. 10 pixels based on either the context is provided or not.
| @@ -456,16 +456,6 @@ export function getThemedComponents(theme: Theme): { components: Theme['componen | |||
| }, | |||
| }, | |||
| }, | |||
| MuiContainer: { | |||
There was a problem hiding this comment.
This contradicts the default values we have for the <Container> that we have in MUI System as best practices.
danilo-leal
reviewed
Aug 2, 2022
Co-authored-by: danilo leal <[email protected]>
siriwatknp
approved these changes
Aug 4, 2022
@siriwatknp I have tried, but it doesn't reproduce the experience well. The best is to open:
and compare with a screen width of 1000px and 1400px |
oliviertassinari
changed the title
oliviertassinari
added
blog
bug 🐛
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the current width on medium size devices is buggy. The had overlooked the max width logic.
Implement #33670 (comment). I have also updated https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917#b51c4255803840479e39cf2861af7ed8.
Preview: https://deploy-preview-33706--material-ui.netlify.app/blog/aggregation-functions/