[Stack][joy] Add new component #33800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
component: Stack
|
@mui/joy: parsed: +1.06% , gzip: +1.34% |
|
Thanks
…On Thu, Aug 4, 2022, 9:49 AM MUI Bot ***@***.***> wrote:
Bundle size will be reported once CircleCI build #413438
<https://app.circleci.com/pipelines/github/mui/material-ui/jobs/413438>
finishes.
Generated by 🚫 dangerJS <https://danger.systems/js> against 7f4683a
<7f4683a>
—
Reply to this email directly, view it on GitHub
<#33800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2KTIJ3BZOYXGKLC43AD7WDVXPJ7RANCNFSM55S2NJXQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
siriwatknp
reviewed
Aug 5, 2022
| createStyledComponent: styled('div', { | ||
| name: 'JoyStack', | ||
| slot: 'Root', | ||
| overridesResolver: (props, styles) => styles.root, |
There was a problem hiding this comment.
We might not need this in the future because layout components do not require theming.
There was a problem hiding this comment.
I was thinking the same thing. Again, I think once we have all components in all packages, we should do a pass and fix inconsistencies/improve them.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://codesandbox.io/s/currying-hooks-2f8di1?file=/demo.tsx
I haven't seen any doc for the system components, so I didn't add one for the Stack too. I guess they will be coming afterwards.