[IconButton] Add missing color classes #33820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Zetta56
force-pushed
the
icon-colors-33615
branch
from
16ec66f to
a2b747c
Compare
pratikkarad
suggested changes
Aug 8, 2022
Comment on lines
+16
to
+24
| /** Styles applied to the root element if `color="error"`. */ | ||
| colorError: string; | ||
| /** Styles applied to the root element if `color="info"`. */ | ||
| colorInfo: string; | ||
| /** Styles applied to the root element if `color="success"`. */ | ||
| colorSuccess: string; | ||
| /** Styles applied to the root element if `color="warning"`. */ | ||
| colorWarning: string; |
There was a problem hiding this comment.
Please add unit tests for these color classes, Thanks!
There was a problem hiding this comment.
I added some unit tests. How do they look?
Zetta56
force-pushed
the
icon-colors-33615
branch
3 times, most recently
from
3a7f8e5 to
aaaba69
Compare
pratikkarad
approved these changes
Aug 9, 2022
Comment on lines
+16
to
+24
| /** Styles applied to the root element if `color="error"`. */ | ||
| colorError: string; | ||
| /** Styles applied to the root element if `color="info"`. */ | ||
| colorInfo: string; | ||
| /** Styles applied to the root element if `color="success"`. */ | ||
| colorSuccess: string; | ||
| /** Styles applied to the root element if `color="warning"`. */ | ||
| colorWarning: string; |
|
Huh, looks like this still needs approval. Did something go wrong? |
oliviertassinari
requested review from
michaldudak and
mnajdova
as code owners
michaldudak
added
the
component: icon button
Comment on lines
99
to
102
| it('should render the primary class', () => { | ||
| const { getByRole } = render(<IconButton color="primary">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorPrimary); | ||
| }); | ||
| it('should render the secondary class', () => { | ||
| const { getByRole } = render(<IconButton color="secondary">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorSecondary); | ||
| }); | ||
| it('should render the error class', () => { | ||
| const { getByRole } = render(<IconButton color="error">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorError); | ||
| }); | ||
| it('should render the info class', () => { | ||
| const { getByRole } = render(<IconButton color="info">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorInfo); | ||
| }); | ||
| it('should render the success class', () => { | ||
| const { getByRole } = render(<IconButton color="success">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorSuccess); | ||
| }); | ||
| it('should render the warning class', () => { | ||
| const { getByRole } = render(<IconButton color="warning">book</IconButton>); | ||
| const button = getByRole('button'); | ||
|
|
||
| expect(button).to.have.class(classes.colorWarning); | ||
| }); |
There was a problem hiding this comment.
I think we can refactor this by using forEach loop iterating on ['primary', 'secondary', 'error', ....] array containing classes and keep the test small.
Zetta56
force-pushed
the
icon-colors-33615
branch
2 times, most recently
from
aef41cc to
e6698d5
Compare
pratikkarad
suggested changes
Nov 26, 2022
Zetta56
force-pushed
the
icon-colors-33615
branch
from
cd6849f to
009a6a6
Compare
Zetta56
force-pushed
the
icon-colors-33615
branch
2 times, most recently
from
9d06bda to
ac10c92
Compare
pratikkarad
approved these changes
Nov 27, 2022
ZeeshanTamboli
approved these changes
Nov 28, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the error, info, success, and warning colors to the
iconButtonClasses.tsfile.fixes #33615