Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update the order of operations for pagination example so that slicing takes place after sorting. #34189

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[docs] Update the order of operations for pagination example so that slicing takes place after sorting. #34189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f693517
Update order of operations for pagination example
marceliwac Sep 4, 2022
f106bed
chore(docs): Linter changes.
marceliwac Oct 12, 2022
a19794e
Merge remote-tracking branch 'mui/master' into patch-1
marceliwac Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/material/components/tables/EnhancedTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ export default function EnhancedTable() {
/>
<TableBody>
{/* if you don't need to support IE11, you can replace the `stableSort` call with:
rows.slice().sort(getComparator(order, orderBy)) */}
rows.sort(getComparator(order, orderBy)).slice() */}
{stableSort(rows, getComparator(order, orderBy))
.slice(page * rowsPerPage, page * rowsPerPage + rowsPerPage)
.map((row, index) => {
Expand Down
2 changes: 1 addition & 1 deletion docs/data/material/components/tables/EnhancedTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export default function EnhancedTable() {
/>
<TableBody>
{/* if you don't need to support IE11, you can replace the `stableSort` call with:
rows.slice().sort(getComparator(order, orderBy)) */}
rows.sort(getComparator(order, orderBy)).slice() */}
{stableSort(rows, getComparator(order, orderBy))
.slice(page * rowsPerPage, page * rowsPerPage + rowsPerPage)
.map((row, index) => {
Expand Down