Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Revise the Joy UI "Global variants" page #34595

Merged
merged 3 commits into from
Oct 14, 2022
Merged

[docs] Revise the Joy UI "Global variants" page #34595

merged 3 commits into from
Oct 14, 2022

Conversation

mapache-salvaje
Copy link
Contributor

Part of #33998

This PR revises the Joy UI "Global variants" page.

I rewrote the intro text to put the most important information at the very top, along with the demo that shows off the variants. I think this will give most readers everything they need as soon as they land on the page.

I also renamed the final section to try to make it more obvious what you'll learn about if you read that section. And I tweaked the name of the second demo because I've never heard the word "importancy" before. 😁

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Oct 3, 2022
@mui-bot
Copy link

mui-bot commented Oct 3, 2022

No bundle size changes

Generated by 🚫 dangerJS against 51b9021

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mapache-salvaje mapache-salvaje merged commit 30f64b3 into mui:master Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@mapache-salvaje mapache-salvaje deleted the global-variants branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants